bgpd: remove dead label code in bgp_update #15305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Feb 6, 2024
| @@ -4218,10 +4218,6 @@ void bgp_update(struct peer *peer, const struct prefix *p, uint32_t addpath_id, | |||
| if (orig_safi == SAFI_LABELED_UNICAST) | |||
| safi = SAFI_UNICAST; | |||
|
|
|||
| memset(&new_attr, 0, sizeof(new_attr)); | |||
There was a problem hiding this comment.
I think we should initialize at least it at the declaration struct attr new_attr = {};, to avoid some tricky edge cases? (don't know if coverity does not complain too)
No need to init new_attr. It is not used until it is overridden. > new_attr = *attr; Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
label-dead-code
branch
from
5b45ba0 to
0603626
Compare
riw777
approved these changes
Feb 6, 2024
ton31337
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to init new_attr. It is not used until it is overridden.